Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Danielle Adam's key as well as keyservers #225

Merged
merged 1 commit into from Dec 1, 2021

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Oct 15, 2021

Deprecate Danielle's old key as DanielleAdamOld

Updated the keyserver from "pool.sks-keyservers.net" -> "hkp://pgp.mit.edu:11371" as the old sks-keyserver is deprecated: https://unix.stackexchange.com/questions/656205/sks-keyservers-gone-what-to-use-instead

Updated KEYS file (#214)

Deprecate her old key as DanielleAdamOld

Updated the keyserver from "pool.sks-keyservers.net" -> "hkp://pgp.mit.edu:11371" as the old sks-keyserver is deprecated: https://unix.stackexchange.com/questions/656205/sks-keyservers-gone-what-to-use-instead
Updated KEYS file (GoogleCloudPlatform#214)
@google-cla google-cla bot added the cla: yes label Oct 15, 2021

for key in ${keylist} ; do
gpg2 --keyserver pool.sks-keyservers.net --recv-keys ${key}
gpg2 --keyserver hkp://pgp.mit.edu:11371 --recv-keys ${key}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me understand this change?

Seems like pool.sks-keyservers.net is deprecated. How reliable and stable is hkp://pgp.mit.edu:11371?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About pgp.mit.edu: https://pgp.mit.edu/about.html
About hkp: https://datatracker.ietf.org/doc/html/draft-shaw-openpgp-hkp-00
11371 is HKP default port

The future of nodejs release key next year is likely to use: https://github.com/nodejs/release-keys

For the upcoming 1-2 year, I think the mit host should be robust enough - it's unlikely they would need to shutdown their keyserver due to DMCA (like sks) given their nature as an education institution.

@patrickpistor
Copy link

Good change +1

Copy link

@danielleadams danielleadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍🏼

@OleksiiKachan
Copy link

@danielleadams can this one be merged please?

@jinglundong
Copy link
Collaborator

FYI, I'm requesting permissions to merge this change.

@jinglundong jinglundong merged commit c027066 into GoogleCloudPlatform:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants