fix(tests): run/logging-manual test failures (#1637) #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
fhinkel
approved these changes
Mar 31, 2020
fhinkel
added
kokoro:run
kokoro-team
removed
the
kokoro:run
|
@fhinkel I don't have good insight into whether it's been proving flaky. If it seems stable to you I'm okay with making it required. |
This was referenced Mar 31, 2020
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1637
run/logging-manual tests started failing due to a compatibility break in upgrading to
got v10#1557. This was not caught because the brokengotfeature is only used in system tests.