Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-3534): increasing maxattempts to wait for metadata in entries to populate #3638

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix(issue-3534): increasing maxattempts to wait for metadata in entries to populate #3638

merged 2 commits into from
Mar 8, 2024

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Mar 8, 2024 •
edited

Description

Fixes #3534 & #3535

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin
refactor: increasing maxattempts to wait for metadata in entries to p…
970830c 
…opulate before trace and labels properties asserts
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Mar 8, 2024
@pattishin pattishin marked this pull request as ready for review March 8, 2024 19:31
@pattishin pattishin requested review from a team as code owners March 8, 2024 19:31
iennae
iennae approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pattishin pattishin merged commit 39aed24 into main Mar 8, 2024
30 checks passed
@pattishin pattishin deleted the fix/issue-3534 branch March 8, 2024 21:05
@pattishin pattishin mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

@iennae iennae iennae approved these changes

Assignees

@grayside grayside

@glasnt glasnt

@iennae iennae

@gericdong gericdong

Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run/logging-manual: uses "trace" property as entry trace failed
6 participants
@pattishin @grayside @iennae @glasnt @jping0220 @gericdong