Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GCF samples from docs into Github #604

Merged
merged 17 commits into from
Apr 30, 2018
Merged

Move GCF samples from docs into Github #604

merged 17 commits into from
Apr 30, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Apr 25, 2018

Do not merge until we figure out what our testing plan for these is.

cc @jasonpolites @emesx

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 25, 2018
@ace-n ace-n requested a review from jmdobry April 25, 2018 23:12
@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #604 into master will decrease coverage by 51.47%.
The diff coverage is 48.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #604       +/-   ##
===========================================
- Coverage     100%   48.52%   -51.48%     
===========================================
  Files           1        1               
  Lines           3       68       +65     
===========================================
+ Hits            3       33       +30     
- Misses          0       35       +35
Impacted Files Coverage Δ
functions/tips/index.js 48.52% <48.52%> (ø)
functions/uuid/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11163d...db5b186. Read the comment docs.

@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 30, 2018
@ace-n
Copy link
Contributor Author

ace-n commented Apr 30, 2018

@jmdobry - this should be good to review now.

(Some of these samples are tested, and Marek has reviewed the rest. If you think it's worth getting to 100% test coverage, let me know and I'll add that.)

@ace-n ace-n merged commit 70d9b39 into master Apr 30, 2018
@ace-n ace-n deleted the extract-gcf-samples branch April 30, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants