Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "shim" (mini-emulator) for GCF functions #623

Merged
merged 10 commits into from
Jul 20, 2018
Merged

Add "shim" (mini-emulator) for GCF functions #623

merged 10 commits into from
Jul 20, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 23, 2018

@stew-r FYI

@ace-n ace-n requested a review from jmdobry May 23, 2018 00:47
@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04340fc...3f3bd74. Read the comment docs.

@@ -24,14 +24,16 @@
"safe-buffer": "5.1.1"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "2.2.5",
"@google-cloud/nodejs-repo-tools": "^2.2.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! 🙏

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 5, 2018
@ace-n ace-n added the GCF Docs label Jul 12, 2018
@ace-n ace-n merged commit e49ef8d into master Jul 20, 2018
@ace-n ace-n deleted the testing-snippets branch July 20, 2018 23:21
grayside pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 12, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
…e already had skip tag (#623)

Co-authored-by: Eric Schmidt <erschmid@google.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
…e already had skip tag (#623)

Co-authored-by: Eric Schmidt <erschmid@google.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
…e already had skip tag (#623)

Co-authored-by: Eric Schmidt <erschmid@google.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
…e already had skip tag (#623)

Co-authored-by: Eric Schmidt <erschmid@google.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
…e already had skip tag (#623)

Co-authored-by: Eric Schmidt <erschmid@google.com>
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants