Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sample not used in docs #833

Closed
wants to merge 4 commits into from
Closed

Delete sample not used in docs #833

wants to merge 4 commits into from

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Nov 8, 2018

Language slackbot is not used in our documentation, i.e., it
does not use region tags.

Current version of repo-tools does not work with protobufs required
for slackbot sample.

cc @amygdala

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
@fhinkel fhinkel changed the title Delete sample not used in dos Delete sample not used in docs Nov 8, 2018
fhinkel and others added 2 commits November 8, 2018 12:02
Language slackbot is not used in our documentation, i.e., it
does not use region tags.

Current version of repo-tools does not work with protobufs required
for slackbot sample.
@fhinkel
Copy link
Contributor Author

fhinkel commented Nov 9, 2018

Talking to @amygdala , there's a blogpost pointing to this sample. They'll have a look next week checking if they can link the blogpost to another copy of this sample. Let's wait until then before we merge this.

@amygdala
Copy link
Contributor

I think I fixed things... or at least, the updated version runs for me.
#879

@fhinkel fhinkel closed this Nov 13, 2018
@jmdobry jmdobry deleted the slackbot branch December 13, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants