Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements for development guide #121

Merged
merged 2 commits into from
Jul 29, 2017

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jul 28, 2017

As I went through the build the first time (both cloud and local) I ran into two issues:

  • my user did not have docker group setup - and that is assumed by the build script, so I mentioned that assumption explicitly in the guide
  • for the "local emulation" of the cloud build, a python script is pulled in from the python runtime - which is not an ideal solution necessarily - especially that the old version (the one I switched back to) worked, the new version doesn't, as it got modularized in this commit - I'll put in an issue to have a better fix than just depending on an older version

balopat and others added 2 commits July 28, 2017 14:51
noted that user needs to have permissions for docker without sudo
@aslo
Copy link
Contributor

aslo commented Jul 28, 2017

👍 Thanks for the improvements to the build process!

I'm also not crazy about the way we currently do local emulation of cloud builds. We can tackle this in a separate issue, but I might even prefer to remove it altogether, since maven is the recommended way to build locally. We've already done that in the Jetty repo. @meltsufin what do you think?

Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balopat Thanks for the improvement and opening that issue to track local build story. This looks good.

@balopat balopat merged commit df6a8b1 into GoogleCloudPlatform:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants