Fix difference between GAE_IMAGE_LABEL and actual image tag when released #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslo PTAL |
meltsufin
force-pushed
the
image_label_fix
branch
from
d9c34e4
to
6e15b75
Compare
gregw
approved these changes
Feb 21, 2017
scripts/cloudbuild.sh
Outdated
| @@ -20,7 +20,7 @@ projectRoot=`dirname $0`/.. | |||
|
|
|||
| DOCKER_NAMESPACE='gcr.io/$PROJECT_ID' | |||
| RUNTIME_NAME="openjdk" | |||
| CANDIDATE_NAME="8-`date +%Y-%m-%d_%H_%M`" | |||
| export CANDIDATE_NAME="8-`date +%Y-%m-%d-%H-%M`" | |||
There was a problem hiding this comment.
Why is it CANDIDATE_NAME rather than LABEL? Other than that, this is good and builds fine for me.
There was a problem hiding this comment.
👍 maybe it makes sense to change this to LONG_TAG to match what's in the pom?
There was a problem hiding this comment.
I'll go with DOCKER_TAG_LONG to match terminology in POM.
aslo
reviewed
Feb 21, 2017
| @@ -28,12 +28,14 @@ | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
| <maven.build.timestamp.format>yyyy-MM-dd_HH_mm</maven.build.timestamp.format> | |||
| <maven.build.timestamp.format>yyyy-MM-dd-HH-mm</maven.build.timestamp.format> | |||
There was a problem hiding this comment.
Just curious, what's the reason for changing the underscores to hyphens here?
There was a problem hiding this comment.
It's for consistency with jetty-runtime mostly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.