Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change POST to PUT when Uploading Fhir data TO the Fhir Store #98

Closed
mozzy11 opened this issue Jan 28, 2021 · 2 comments
Closed

Change POST to PUT when Uploading Fhir data TO the Fhir Store #98

mozzy11 opened this issue Jan 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working P1:must As issue that definitely needs to be implemented in near future.

Comments

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 28, 2021

Uploading Resources by POST ,forces the Hapi fhir server to strictly create New Resources and generates a new internal Resource ID.
This leads to data duplication in case the same resource is POSTed more than Once .
When handling Referential Integrity ,Hapi generates new dummy resources which continuously leads to unnecessary data duplication .
see Talk Post for more details.
This should be implemented both in Streaming and Batch modes.

@bashir2 bashir2 added bug Something isn't working P1:must As issue that definitely needs to be implemented in near future. labels Jan 28, 2021
@bashir2
Copy link
Collaborator

bashir2 commented Jan 28, 2021

Thanks @mozzy11 for catching this issue; I am marking this as a "bug" since this is a regression and the original intention was to keep the resource IDs. I am not sure if there is any case where we would need POST instead of PUT because of the broken referential integrity issue but adding @pmanko to make sure this behavior is okay with his use-case.

@mozzy11 mozzy11 self-assigned this Feb 5, 2021
@mozzy11
Copy link
Collaborator Author

mozzy11 commented Feb 5, 2021

Pr here #109

@bashir2 bashir2 closed this as completed in 9fcf36e Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1:must As issue that definitely needs to be implemented in near future.
Projects
None yet
Development

No branches or pull requests

2 participants