Lint checks

GoogleCloudPlatform · May 24, 2023 · 3d9692e · 3d9692e
1 parent e9d978f
commit 3d9692e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/exporter/collector/integrationtest/testcases/testcases_metrics.go b/exporter/collector/integrationtest/testcases/testcases_metrics.go
@@ -230,7 +230,7 @@ var MetricsTestCases = []TestCase{
 		},
 	},
 	{
-		Name: "Write ahead log enabled",
+		Name:                 "Write ahead log enabled",
 		OTLPInputFixturePath: "testdata/fixtures/metrics/basic_counter_metrics.json",
 		ExpectFixturePath:    "testdata/fixtures/metrics/basic_counter_metrics_wal_expect.json",
 		ConfigureCollector: func(cfg *collector.Config) {

diff --git a/exporter/collector/metrics.go b/exporter/collector/metrics.go
@@ -341,7 +341,11 @@ func (me *MetricsExporter) PushMetrics(ctx context.Context, m pmetric.Metrics) e
 					errs = append(errs, fmt.Errorf("failed to marshal protobuf to bytes: %+v", err))
 					continue
 				}
-				me.wal.Write(me.wWALIndex.Add(1), bytes)
+				err = me.wal.Write(me.wWALIndex.Add(1), bytes)
+				if err != nil {
+					errs = append(errs, fmt.Errorf("failed to write to WAL: %+v", err))
+					continue
+				}
 			} else {
 				// otherwise export directly
 				err := me.export(ctx, req)
@@ -405,7 +409,7 @@ func (me *MetricsExporter) readWALAndExport(ctx context.Context) error {
 		bytes, err := me.wal.Read(me.rWALIndex.Load())
 		if err == nil {
 			req := new(monitoringpb.CreateTimeSeriesRequest)
-			if err := proto.Unmarshal(bytes, req); err != nil {
+			if err = proto.Unmarshal(bytes, req); err != nil {
 				return err
 			}