Add some unit tests

GoogleCloudPlatform · Jun 14, 2023 · 41f1009 · 41f1009
1 parent ce23f6a
commit 41f1009
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/exporter/collector/metrics.go b/exporter/collector/metrics.go
@@ -214,7 +214,6 @@ func NewGoogleCloudMetricsExporter(
 	}
 
 	if cfg.MetricConfig.WALConfig != nil {
-		mExp.wal = &exporterWAL{}
 		_, _, err = mExp.setupWAL()
 		if err != nil {
 			return nil, err
@@ -240,6 +239,10 @@ func (me *MetricsExporter) setupWAL() (uint64, uint64, error) {
 		return 0, 0, err
 	}
 
+	if me.wal == nil {
+		me.wal = &exporterWAL{}
+	}
+
 	walPath := filepath.Join(me.cfg.MetricConfig.WALConfig.Directory, "gcp_metrics_wal")
 	me.wal.path = walPath
 	metricWal, err := wal.Open(walPath, &wal.Options{LogFormat: 1})

diff --git a/exporter/collector/metrics_test.go b/exporter/collector/metrics_test.go
@@ -17,6 +17,7 @@ package collector
 import (
 	"fmt"
 	"math"
+	"os"
 	"testing"
 	"time"
 
@@ -2033,3 +2034,53 @@ func TestInstrumentationScopeToLabelsUTF8(t *testing.T) {
 		})
 	}
 }
+
+func TestSetupWAL(t *testing.T) {
+	tmpDir, _ := os.MkdirTemp("", "wal-test-")
+	mExp := &MetricsExporter{
+		cfg: Config{
+			MetricConfig: MetricConfig{
+				WALConfig: &WALConfig{
+					Directory:  tmpDir,
+					MaxBackoff: time.Duration(2112 * time.Second),
+				},
+			},
+		},
+	}
+	firstIndex, lastIndex, err := mExp.setupWAL()
+	require.NoError(t, err)
+	require.Zero(t, firstIndex)
+	require.Zero(t, lastIndex)
+	require.Equal(t, time.Duration(2112*time.Second), mExp.wal.maxBackoff)
+
+	mExp.wal.Write(uint64(1), []byte("foo"))
+	mExp.wal.Write(uint64(2), []byte("bar"))
+	firstIndex, lastIndex, err = mExp.setupWAL()
+	require.NoError(t, err)
+	require.Equal(t, uint64(1), firstIndex)
+	require.Equal(t, uint64(2), lastIndex)
+	require.Equal(t, time.Duration(2112*time.Second), mExp.wal.maxBackoff)
+}
+
+func TestCloseWAL(t *testing.T) {
+	tmpDir, _ := os.MkdirTemp("", "wal-test-")
+	mExp := &MetricsExporter{
+		cfg: Config{
+			MetricConfig: MetricConfig{
+				WALConfig: &WALConfig{
+					Directory:  tmpDir,
+					MaxBackoff: time.Duration(2112 * time.Second),
+				},
+			},
+		},
+	}
+	_, _, err := mExp.setupWAL()
+	require.NoError(t, err)
+
+	err = mExp.closeWAL()
+	require.NoError(t, err)
+
+	// check multiple closes are safe
+	err = mExp.closeWAL()
+	require.NoError(t, err)
+}