Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trace exporter options that don't belong in the exporter #188

Closed
dashpole opened this issue Jul 20, 2021 · 0 comments · Fixed by #191
Closed

Remove trace exporter options that don't belong in the exporter #188

dashpole opened this issue Jul 20, 2021 · 0 comments · Fixed by #191

Comments

@dashpole
Copy link
Contributor

The exporter should only have options related to exporting, and should not include options related to modifying telemetry before it is sent. Those should probably be done using a SpanProcessor instead of exporter options.

Options we should remove include:
dashpole added a commit to dashpole/opentelemetry-operations-go that referenced this issue Jul 20, 2021
@dashpole
remove DesplayNameFormatter and DefaultTraceAttributes from the expor…
1122ab5 
…ter options. Fixes GoogleCloudPlatform#188
dashpole added a commit to dashpole/opentelemetry-operations-go that referenced this issue Jul 20, 2021
@dashpole
remove DisplayNameFormatter and DefaultTraceAttributes from the expor…
18cc4c2 
…ter options. Fixes GoogleCloudPlatform#188
@dashpole dashpole mentioned this issue Jul 20, 2021
Merged
punya pushed a commit that referenced this issue Jul 27, 2021
@dashpole
remove DisplayNameFormatter and DefaultTraceAttributes from the expor…
44a5968 
…ter options. Fixes #188 (#191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dashpole