Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Unix epoch (1970) as default starttimestamp #335

Closed
danelowe opened this issue Mar 28, 2022 · 1 comment
Closed

Allow Unix epoch (1970) as default starttimestamp #335

danelowe opened this issue Mar 28, 2022 · 1 comment

Comments

@danelowe
Copy link

It appears as though the opentelemetry-collector might be adding 1970-01-01 as the default value for StartTimestamp on TimeSeries DataPoints.

if (!ok && point.StartTimestamp().AsTime().IsZero()) || !point.StartTimestamp().AsTime().Before(point.Timestamp().AsTime()) {

Here the code expects it to be 0001-01-01, resulting in data not being sent to Google Cloud.

Also opentelemetry-collector stores timestamps as unsigned integers from 1970, so can't set the StartTimestamp to 0001-01-01 without counting on integer overflows.

open-telemetry/opentelemetry-collector#5102

@dashpole
Copy link
Contributor

This was fixed in #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants