Do not use IsZero on timestamps obtained from pdata #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
reviewed
Mar 28, 2022
| @@ -586,6 +586,7 @@ func TestSummaryPointToTimeSeries(t *testing.T) { | |||
| quantile.SetQuantile(1.0) | |||
| quantile.SetValue(1.0) | |||
| end := start.Add(time.Hour) | |||
| point.SetStartTimestamp(pdata.NewTimestampFromTime(start)) | |||
There was a problem hiding this comment.
should we add a test for the 0 value conversion?
There was a problem hiding this comment.
Zero is the default value, so it was being implicitly used in one of the tests. I made that usage explicit in the most recent commit.
There was a problem hiding this comment.
Ah, sounds good to me. Think I get it now
damemi
approved these changes
Mar 28, 2022
| @@ -586,6 +586,7 @@ func TestSummaryPointToTimeSeries(t *testing.T) { | |||
| quantile.SetQuantile(1.0) | |||
| quantile.SetValue(1.0) | |||
| end := start.Add(time.Hour) | |||
| point.SetStartTimestamp(pdata.NewTimestampFromTime(start)) | |||
There was a problem hiding this comment.
Ah, sounds good to me. Think I get it now
damemi
added a commit
that referenced
this pull request
Apr 11, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <dashpole@google.com> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <dashpole@google.com> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * make gotidy * React to rebase Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Marc Dougherty <muncus@users.noreply.github.com>
damemi
added a commit
to damemi/opentelemetry-operations-go
that referenced
this pull request
Apr 19, 2022
* Do not use IsZero on timestamps obtained from pdata (GoogleCloudPlatform#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (GoogleCloudPlatform#338) * drop data points with no value set (GoogleCloudPlatform#339) * handle NaN sums in histograms and exponential histograms (GoogleCloudPlatform#340) * Fix broken links, typos in docs (GoogleCloudPlatform#345) * Update fixtures based on upstream changes to the prometheus receiver (GoogleCloudPlatform#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (GoogleCloudPlatform#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <dashpole@google.com> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <dashpole@google.com> * Demonstrate that integration tests aren't catching failures (GoogleCloudPlatform#349) * demonstrate that integration tests aren't catching failures * Update dependencies (GoogleCloudPlatform#347) update dependencies * make gotidy * React to rebase Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Marc Dougherty <muncus@users.noreply.github.com>
damemi
added a commit
that referenced
this pull request
Apr 20, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <dashpole@google.com> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <dashpole@google.com> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * address remaining nits from #347 (#351) * prepare for release (#353) * add integration test with metrics from the prometheus receiver (#348) * add make commands for release (#354) * Send timeseries synchronously (#358) * send timeseries syncronously * update docs, and fix existing broken test * Drop histograms without a sum (#359) * update opentelemetry collector to v0.49.0 * drop histograms without a sum * Update logging export to use new v0.49 types Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Marc Dougherty <muncus@users.noreply.github.com>
damemi
added a commit
that referenced
this pull request
Apr 29, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <dashpole@google.com> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <dashpole@google.com> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * address remaining nits from #347 (#351) * prepare for release (#353) * add integration test with metrics from the prometheus receiver (#348) * add make commands for release (#354) * Send timeseries synchronously (#358) * send timeseries syncronously * update docs, and fix existing broken test * Drop histograms without a sum (#359) * update opentelemetry collector to v0.49.0 * drop histograms without a sum * Add sum of squared deviation estimate (#341) * add sum of squared deviation estimate * Add missing otel attributes to Spans exported to Cloud Trace (#365) * Add instrumentation library to span attributes. * Add test to ensure resource + instrumentation-scope labels show up in spans. * Expand testing. * Move resource mapping into shared module, and add monitored resource labels to trace spans. * Do the go mod tidy shuffle. * Fix docker build to include new shared module. * Bump back to go 1.17 * Migrate to SDK version of semantic convention constants instead of Collector's. * Clean up documents. * Normalize histograms, summaries, and exponential histograms (#360) * normalize remaining cumulative data points * use the timeout passed to the metrics exporter (#369) * make gotidy * Resolve conflicts from missed file Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Marc Dougherty <muncus@users.noreply.github.com> Co-authored-by: Josh Suereth <joshuasuereth@google.com>
damemi
added a commit
that referenced
this pull request
Apr 29, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <dashpole@google.com> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <dashpole@google.com> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * address remaining nits from #347 (#351) * prepare for release (#353) * add integration test with metrics from the prometheus receiver (#348) * add make commands for release (#354) * Send timeseries synchronously (#358) * send timeseries syncronously * update docs, and fix existing broken test * Drop histograms without a sum (#359) * update opentelemetry collector to v0.49.0 * drop histograms without a sum * Add sum of squared deviation estimate (#341) * add sum of squared deviation estimate * Add missing otel attributes to Spans exported to Cloud Trace (#365) * Add instrumentation library to span attributes. * Add test to ensure resource + instrumentation-scope labels show up in spans. * Expand testing. * Move resource mapping into shared module, and add monitored resource labels to trace spans. * Do the go mod tidy shuffle. * Fix docker build to include new shared module. * Bump back to go 1.17 * Migrate to SDK version of semantic convention constants instead of Collector's. * Clean up documents. * Normalize histograms, summaries, and exponential histograms (#360) * normalize remaining cumulative data points * use the timeout passed to the metrics exporter (#369) Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Marc Dougherty <muncus@users.noreply.github.com> Co-authored-by: Josh Suereth <joshuasuereth@google.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: open-telemetry/opentelemetry-collector#5102. It isn't possible to round-trip timestamps before 1970 in the pdata timestamp package. An unset timestamp would be Timestamp(0), which returns false for AsTime().IsZero()