New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update otel to v0.12.0 #101
Update otel to v0.12.0 #101
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
9a80814
to
0994217
Compare
A merge and release of this PR would be really appreciated by the opentelemetry-collector-contrib repo |
It would be great to have this. I'll just note that you can't use go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one minor comment.
Since this PR is blocking people I will merge it now, but can you please check the comment below and fix in a new PR if correct?
if err != nil { | ||
return nil, nil, err | ||
} | ||
tp := sdktrace.NewTracerProvider(append(topts, sdktrace.WithSyncer(exporter))...) | ||
return tp, exporter.traceExporter.Flush, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be somewhat cleaner if we returned exporter.Shutdown
here instead or exporter.traceExporter.Flush
?
No description provided.