Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel to v0.12.0 #101

Merged

Conversation

yas-okadatech
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 1, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bogdandrutu
Copy link
Collaborator

A merge and release of this PR would be really appreciated by the opentelemetry-collector-contrib repo

@mrothroc
Copy link

mrothroc commented Oct 2, 2020

It would be great to have this. I'll just note that you can't use go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
to trace gRPC calls in google cloud without this PR because that module requires 0.12.0

Copy link
Contributor

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one minor comment.

Since this PR is blocking people I will merge it now, but can you please check the comment below and fix in a new PR if correct?

if err != nil {
return nil, nil, err
}
tp := sdktrace.NewTracerProvider(append(topts, sdktrace.WithSyncer(exporter))...)
return tp, exporter.traceExporter.Flush, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be somewhat cleaner if we returned exporter.Shutdown here instead or exporter.traceExporter.Flush?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants