Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #143 - Span status should map rpc status. #150

Merged
merged 1 commit into from Mar 5, 2021
Merged

Fix #143 - Span status should map rpc status. #150

merged 1 commit into from Mar 5, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Mar 5, 2021

  • Update mapping of status code to match trace exporter specification
  • Update tests to abide by OTel Specification on "message"
  • Update status code mapping to send status in more scenarios

@jsuereth jsuereth requested a review from aabmass March 5, 2021 18:47
@aabmass aabmass linked an issue Mar 5, 2021 that may be closed by this pull request
OpenTelemetry span status code does not map directly to google.rpc.Code #143
Closed
@jsuereth jsuereth merged commit 8f77e63 into main Mar 5, 2021
@jsuereth jsuereth deleted the fix-status-code branch March 5, 2021 22:56
@punya punya mentioned this pull request Mar 8, 2021
Merged
This was referenced Mar 11, 2021
Open
Closed
Closed
Closed
Open
Open
Closed
Open
Closed
Open
Open
Closed
Closed
Open
Open
Open
Closed
Closed
Closed
Open
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry span status code does not map directly to google.rpc.Code
2 participants
@jsuereth @aabmass