Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenTelemetry has been updated to v1.0.0-RC1 I am sending this PR.
Changes are:
ReadOnlySpan
WithDefaultTraceAttributes
function andDefaultTraceAttributes
are removed since it is not possible to add attributes toReadOnlySpan
injectLabelsFromResources
is removed since you can't inject anything to aReadOnlySpan
. Instead,attributeWithLabelsFromResources
returns all attributes with labels from resources.injectLabelsFromResources
are removed since mockingReadOnlySpan
could lead to a problem in future. Although it might be an option to changeattributeWithLabelsFromResources
's signature to get an interface like this:With this we can mock an interface to be able to test this function.