-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support metric exporter #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not tested with SD backend, please test one metric of type Observer and Counter with the backend.
See other inline comments..
@nilebox can you please review this as well. |
The sample sometimes show the rpc error as follows that is relevant to #25 :
|
you could not set the start_time for gauge metric. then it probably won't complain. |
Example: Counter is working. Observer fails with the following error message.
|
Replace #14 with this PR.