Fix 'rpc error: code = InvalidArgument desc = Invalid parent id!' errors #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors. The parent span ID was being formatted incorrectly, which meant all spans except the root span were rejected by the GCP tracing API. If clients did not have error logging hooked up to WithOnError, this would cause child spans to be silently dropped. The documentation says the parent span ID should be formatted as a 64-bit integer encoded as a string, but appears to accept the hexadecimal format returned by SpanID.String().
charleskorn
added a commit
to batect/abacus
that referenced
this pull request
May 17, 2020
This also temporarily replaces the GCP-provided tracing exporter with my fork until GoogleCloudPlatform/opentelemetry-operations-go#27 is merged.
nilebox
reviewed
May 29, 2020
| @@ -84,7 +84,7 @@ func protoFromSpanData(s *export.SpanData, projectID string) *tracepb.Span { | |||
| SameProcessAsParentSpan: &wrapperspb.BoolValue{Value: !s.HasRemoteParent}, | |||
| } | |||
| if s.ParentSpanID != s.SpanContext.SpanID && s.ParentSpanID.IsValid() { | |||
| sp.ParentSpanId = fmt.Sprintf("%.16x", s.ParentSpanID) | |||
There was a problem hiding this comment.
This line was originally introduced in open-telemetry/opentelemetry-go#160 and then was moved to this repo.
@ymotongpoo was this line imported from OpenCensus? Do OpenCensus and OpenTelemetry have different string representation of SpanIDs?
nilebox
approved these changes
May 29, 2020
rghetia
approved these changes
May 29, 2020
charleskorn
added a commit
to batect/abacus
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent span ID was being formatted incorrectly, which meant all spans except the root span were rejected by the GCP tracing API.
If clients did not have error logging hooked up to
WithOnError(), this would cause child spans to be silently dropped.The API documentation says the span ID should be formatted as a 64-bit integer encoded as a string, but appears to accept a span ID or parent span ID in the hexadecimal format returned by
SpanID.String().I couldn't see any tests for this functionality, so I haven't added any - happy to add some.