Address a bunch of small TODOs #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
approved these changes
Feb 4, 2022
exporter/collector/integrationtest/testdata/fixtures/ops_agent_host_metrics_expect.json
Outdated
Show resolved
Hide resolved
jsuereth
requested changes
Feb 4, 2022
| @@ -83,6 +108,29 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "metric": { | |||
| "type": "custom.googleapis.com/opencensus/grpc.io/client/completed_rpcs", | |||
There was a problem hiding this comment.
I realize this is just the nature of how we did our self observabiltiy metrics, but it's highly confusing seeing the opencensus metrics here when Ops Agent defines its own self-observability metrics, that this test is measuring if we can write those self-observability metrics.
There was a problem hiding this comment.
Ya since this uses OpenCensus instrumentation we sort of have to use the OC exporter to capture them. Should we:
- Tweak the metrics prefix config for the OC exporter or
- Strip out the whole
custom.googleapis.com/opencensus/prefix when saving the fixture
exporter/collector/integrationtest/testdata/fixtures/ops_agent_host_metrics_expect.json
Outdated
Show resolved
Hide resolved
exporter/collector/integrationtest/testdata/fixtures/ops_agent_host_metrics_expect.json
Outdated
Show resolved
Hide resolved
exporter/collector/integrationtest/testdata/fixtures/ops_agent_host_metrics_expect.json
Outdated
Show resolved
Hide resolved
dashpole
force-pushed
the
address_todos
branch
2 times, most recently
from
ae7b1f9
to
716fc6c
Compare
|
@jsuereth when you get the chance, can you re-review? |
dashpole
force-pushed
the
address_todos
branch
from
716fc6c
to
2d6ae6b
Compare
jsuereth
approved these changes
Feb 16, 2022
dashpole
added a commit
to dashpole/opentelemetry-operations-go
that referenced
this pull request
Mar 8, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are either trivial to fix, or already done elsewhere. See commit message for reason for removing each TODO