Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module name for GMP, update docs, and prepare for a patch release. #387

Merged
merged 3 commits into from May 6, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented May 6, 2022

It isn't currently possible to use the GMP exporter because of the module name:

Error: failed to update go.mod: exit status 1. Output: "go: downloading github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus v0.30.0\ngo: github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus@v0.30.0: parsing go.mod:\n\tmodule declares its path as: github.com/dashpole/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus\n\t        but was required as: github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus\n"

I had changed it to dashpole while I was manually testing, but forgot to change it back.

@dashpole dashpole requested a review from damemi May 6, 2022 12:54
@dashpole dashpole merged commit 2dbec0f into GoogleCloudPlatform:main May 6, 2022
@dashpole dashpole deleted the experimental_docs branch May 6, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants