Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally configure service account impersonation #398

Merged
merged 1 commit into from May 20, 2022

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented May 20, 2022

Note: this replaces open-telemetry/opentelemetry-collector-contrib#10173 per a suggestion from @dashpole.

GCP supports authentication using short-lived credentials obtained by
"impersonating" a service account. This is useful for cross-project
access, for example: a service account in one project is trusted to
impersonate a service account in another project and export metrics on
its behalf. This patch adds support for service account impersonation
for metrics, logs, and traces.

See https://cloud.google.com/iam/docs/impersonating-service-accounts for
details.

@dashpole
Copy link
Contributor

/gcbrun

@dashpole dashpole self-assigned this May 20, 2022
@dashpole
Copy link
Contributor

you can run make fieldalignment to fix the linter issue. It might remove comments, so make sure to add any of those back in

@dashpole
Copy link
Contributor

/gcbrun

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

exporter/collector/config.go Show resolved Hide resolved
GCP supports authentication using short-lived credentials obtained by
"impersonating" a service account. This is useful for cross-project
access, for example: a service account in one project is trusted to
impersonate a service account in another project and export metrics on
its behalf. This patch adds support for service account impersonation
for metrics, logs, and traces.

See https://cloud.google.com/iam/docs/impersonating-service-accounts for
details.
@dashpole
Copy link
Contributor

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants