Allow overriding location, cluster, and namespace using metric labels #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xichen2020
approved these changes
May 23, 2022
exporter/collector/googlemanagedprometheus/monitoredresource.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GMP, if you set "location", "cluster" or "namespace" labels on your metrics, they are moved to the monitored resource from the set of labels.
To achieve the same behavior in the otel collector, use a processor to move those labels from metric to resource, and then map those from otel resource to monitored resource. They take precedence over other ways of setting those labels (i.e. a "namespace" label on a KSM metric will be used over the namespace of the KSM exporter.
cc @xichen2020