Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize timestamps in log tests #404

Merged
merged 1 commit into from May 27, 2022
Merged

Normalize timestamps in log tests #404

merged 1 commit into from May 27, 2022

Conversation

dashpole
Copy link
Contributor

This way the time doesn't change each time the fixtures are regenerated. This matches what we do in metric tests

@dashpole dashpole requested a review from damemi May 26, 2022 19:22
@dashpole dashpole marked this pull request as ready for review May 26, 2022 19:22
damemi
damemi approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this bugged me too but I wasn't sure how to fix it

@dashpole dashpole merged commit f78512a into GoogleCloudPlatform:main May 27, 2022
@dashpole dashpole deleted the log_regen branch May 27, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dashpole @damemi