Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default aggregation for Counter, Observer and Recorder #41

Merged
merged 4 commits into from Jun 11, 2020
Merged

Change default aggregation for Counter, Observer and Recorder #41

merged 4 commits into from Jun 11, 2020
+153 −59

Conversation

ymotongpoo
Copy link
Member

@ymotongpoo ymotongpoo self-assigned this Jun 9, 2020
@ymotongpoo
Add support for SumObserver and UpDownSumObserver.
ca3f7b5 
* Add support for SumObserver and UpDownSumObserver
* Fix package name to call for consistency (metric -> apimetric)
* Fix version to use in the metric example
rghetia
rghetia reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits.

exporter/metric/metric.go Show resolved Hide resolved
exporter/metric/selector.go Outdated Show resolved Hide resolved
@ymotongpoo
Copy link
Member Author

@rghetia thank you for reviewing. done fixing.

@rghetia
Copy link
Contributor

rghetia commented Jun 10, 2020

adding comment to trigger CLA.

@rghetia
Copy link
Contributor

rghetia commented Jun 10, 2020

closing and opening to trigger CLA.

@rghetia rghetia closed this Jun 10, 2020
@rghetia rghetia reopened this Jun 10, 2020
@rghetia rghetia merged commit 5fb47d1 into GoogleCloudPlatform:master Jun 11, 2020
@simplylizz
Copy link

Isn't it worth to make a release with this fix? Otherwise, it seems that metrics aren't usable. Sure I can specify a commit in my go.mod, but it took me some time to find out the solution for the issue because I used the latest released version.

@james-bebbington
Copy link
Contributor

Isn't it worth to make a release with this fix? Otherwise, it seems that metrics aren't usable. Sure I can specify a commit in my go.mod, but it took me some time to find out the solution for the issue because I used the latest released version.

I've just made another release. Note that these exporters are still in the process of being built, so expect some breaking changes before v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@nilebox nilebox Awaiting requested review from nilebox

Assignees

@ymotongpoo ymotongpoo

Labels
monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metric - counter example doesn't work properly Handling timestamp appropriately based on MetricKind
4 participants
@ymotongpoo @rghetia @simplylizz @james-bebbington