Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opentelemetry dependencies to the latest release #422

Merged
merged 1 commit into from Jun 16, 2022
Merged

Update opentelemetry dependencies to the latest release #422

merged 1 commit into from Jun 16, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jun 13, 2022 •
edited

Fixes #414

@dashpole dashpole requested a review from damemi June 13, 2022 14:03
@dashpole dashpole marked this pull request as ready for review June 13, 2022 14:03
damemi
damemi reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update looks fine to me but @dashpole the tests are failing, might be some changes needed

@dashpole
Copy link
Contributor Author

yeah...

@dashpole
Copy link
Contributor Author

Step #1 - "run-tests-local": 2022/06/13 17:50:06 could not initialize a tracer-provider: detecting resources: [cannot merge resource due to conflicting Schema URL]

@dashpole
Copy link
Contributor Author

dashpole commented Jun 13, 2022 •
edited

I need open-telemetry/opentelemetry-go-contrib#2341 to merge before I can fix this

Done

@dashpole dashpole marked this pull request as draft June 14, 2022 12:53
@dashpole dashpole force-pushed the update_otel_again branch 2 times, most recently from 6180247 to 7f9c746 Compare June 15, 2022 21:14
@dashpole dashpole marked this pull request as ready for review June 15, 2022 21:20
@dashpole dashpole merged commit 8c27671 into GoogleCloudPlatform:main Jun 16, 2022
@dashpole dashpole deleted the update_otel_again branch June 16, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to the latest open telemetry
2 participants
@dashpole @damemi