Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traces integration tests #457

Merged
merged 5 commits into from Jul 21, 2022

Conversation

damemi
Copy link
Member

@damemi damemi commented Jul 21, 2022

This adds a basic expect/fixture test and integration tests for traces

What's interesting is that we thought this would need some unique traceId generation for the integration test to work (ie, GCP to not reject the duplicate trace id from earlier runs). But running this locally, it seems to work fine.

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@damemi damemi merged commit 2957ea8 into GoogleCloudPlatform:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants