Improve error handling #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
commented
Sep 30, 2022
| @@ -148,14 +147,10 @@ func newMetricExporter(o *options) (*metricExporter, error) { | |||
|
|
|||
| // Export exports OpenTelemetry Metrics to Google Cloud Monitoring. | |||
| func (me *metricExporter) Export(ctx context.Context, rm metricdata.ResourceMetrics) error { | |||
| if err := me.exportMetricDescriptor(ctx, rm); err != nil { | |||
| return err | |||
There was a problem hiding this comment.
this return would've prevented sending TS if we failed to write descriptors.
| for kmd, md := range mds { | ||
| err := me.createMetricDescriptorIfNeeded(ctx, md) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
this return would've prevented other descriptors from being written
|
|
||
| for _, scope := range rm.ScopeMetrics { | ||
| for _, metrics := range scope.Metrics { | ||
| ts, err := me.recordToTspb(metrics, mr, scope.Scope) | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| } else { |
There was a problem hiding this comment.
this else prevented appending timeseries if recordToTspb returned a partial error (an error, and some timeseries)
|
|
||
| if aggError != nil { | ||
| if me.o.onError != nil { | ||
| me.o.onError(aggError) |
There was a problem hiding this comment.
this is removed in-favor of returning the error.
damemi
approved these changes
Sep 30, 2022
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a number of improvements:
nilerrors by not appending, so we aren't required to check fornilanymore.