Run collector metrics integration tests on the SDK metrics exporter #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
integration_testing
branch
3 times, most recently
from
4e29d99
to
1ff9083
Compare
dashpole
force-pushed
the
integration_testing
branch
from
1ff9083
to
bc201d0
Compare
dashpole
commented
Oct 4, 2022
Comment on lines
+136
to
+153
| testServerExporter, err := metric.New( | ||
| metric.WithProjectID("fakeprojectid"), | ||
| metric.WithMonitoringClientOptions( | ||
| apioption.WithEndpoint(testServer.Endpoint), | ||
| apioption.WithoutAuthentication(), | ||
| apioption.WithGRPCDialOption(grpc.WithTransportCredentials(insecure.NewCredentials())), | ||
| ), | ||
| ) | ||
| require.NoError(t, err) | ||
|
|
||
| for _, m := range testcases.ConvertResourceMetrics(metrics) { | ||
| err = testServerExporter.Export(ctx, m) | ||
| if !test.ExpectErr { | ||
| require.NoError(t, err, "Failed to export metrics to local test server") | ||
| } else { | ||
| require.Error(t, err, "Did not see expected error") | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the only section that differs from TestCollectorMetrics above.
dashpole
commented
Oct 4, 2022
| CreateTimeSeriesRequests: testServer.CreateTimeSeriesRequests(), | ||
| CreateMetricDescriptorRequests: testServer.CreateMetricDescriptorRequests(), | ||
| CreateServiceTimeSeriesRequests: testServer.CreateServiceTimeSeriesRequests(), | ||
| // Do not test self-observability metrics with SDK exporters |
There was a problem hiding this comment.
We also don't check self-obs metrics in SDK tests, since those are specific to the collector exporter.
damemi
approved these changes
Oct 4, 2022
|
|
||
| // ConvertResourceMetrics converts a (collector) pdata metrics to an SDK ResourceMetrics | ||
| // This is useful for testing the SDK with the same data used to test the collector. | ||
| func ConvertResourceMetrics(pdataMetrics pmetric.Metrics) []metricdata.ResourceMetrics { |
There was a problem hiding this comment.
the conversion all looks pretty 1:1, but are you worried at all about maintaining these conversions? The metrics sdk is only alpha, so it could still change right?
There was a problem hiding this comment.
It is, but it is spec-compliant (and the spec is stable), and the underlying OTLP datamodel is also stable, so I don't think it is likely to change. pdata APIs are also not stable, so its also a risk. But i'm not too worried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does this by converting from pdata to the sdk metric exporter types.
Since it currently fails the tests (because of differences between the exporters), i've disabled all the tests. I'll reenable them once-at-a-time as I fix the differences.