Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Change default metric prefix for SDK exporter to workload.googleapis.com #495

Merged
merged 1 commit into from Oct 5, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 4, 2022

This aligns with the collector exporter. It is one difference found by integration tests.

@dashpole dashpole requested a review from damemi October 4, 2022 17:58
@damemi
Copy link
Member

damemi commented Oct 5, 2022

How does this kind of breaking change affect users?

@dashpole
Copy link
Contributor Author

dashpole commented Oct 5, 2022

Users can revert to the previous behavior using WithMetricDescriptorTypeFormatter, and adding a prefix custom.googleapis.com/opentelemetry in their formatter function.

Otherwise, this will change the name of metrics sent using this exporter

@dashpole dashpole merged commit 11b8f81 into GoogleCloudPlatform:main Oct 5, 2022
@dashpole dashpole deleted the workload branch October 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants