Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetClientOptions conflicts with default credentials #548

Merged
merged 1 commit into from Dec 20, 2022
Merged

Fix GetClientOptions conflicts with default credentials #548

merged 1 commit into from Dec 20, 2022

Conversation

dashpole
Copy link
Contributor

Fixes #547

Omit default credentials if additional options are provided, as these could conflict.

@dashpole dashpole requested a review from damemi December 19, 2022 18:18
@dashpole dashpole merged commit 13f2c56 into GoogleCloudPlatform:main Dec 20, 2022
@dashpole dashpole deleted the no_default_override branch December 20, 2022 15:25
@cpheps
Copy link

cpheps commented Jan 3, 2023

@dashpole Is it possible to update the googlecloudexporter go.mod with a version of the collector module that has this fix?

I'm not sure if there any other changes since the last version that isn't ready to be upstreamed yet.

@dashpole
Copy link
Contributor Author

dashpole commented Jan 3, 2023

We can try to tag a release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic Credential Lookup in collector exporter make it not possible to set credentials
3 participants
@dashpole @cpheps @damemi