Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMP name normalization #553

Merged
merged 1 commit into from
Jan 4, 2023
Merged

GMP name normalization #553

merged 1 commit into from
Jan 4, 2023

Conversation

dashpole
Copy link
Contributor

Part of #543

Use prometheus.BuildPromCompliantName to add unit and correct suffixes to metric names.

@dashpole dashpole marked this pull request as ready for review January 4, 2023 14:55
@dashpole dashpole requested a review from damemi January 4, 2023 14:55
@dashpole dashpole changed the title WIP GMP name normalization GMP name normalization Jan 4, 2023
@dashpole dashpole merged commit 1c4e091 into GoogleCloudPlatform:main Jan 4, 2023
@dashpole dashpole deleted the gmp_name_normalization branch January 4, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dashpole @damemi