Add github actions tests #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
github_actions
branch
3 times, most recently
from
6820761
to
45bf1c2
Compare
|
See dashpole#1 for the tests running on github actions. |
dashpole
force-pushed
the
github_actions
branch
from
45bf1c2
to
9601222
Compare
|
This is now ready for review. |
damemi
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #554
This keeps all of the individual steps the same, but instead of running make ci, like we do in circleci, it runs each step (generate, build, lint, fixtures, check-clean-work-tree) as a separate step.
It also expands the compatibility matrix we test against to match what the opentelemetry-go repo uses to include testing against two go versions (1.19 and 1.18), testing on linux, windows, and mac.
It also adopts
gocovmerge(github.com/wadey/gocovmerge) to properly merge code coverage reports from each module into a single one.Tests are based on the github actions tests in opentelemetry-go.
After this, I will change the required tests in the repo, and then open a follow-up to remove circleci