Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement push scenario for test server #563

Merged
merged 1 commit into from Jan 10, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jan 9, 2023

This is based on the java implementation. It listens on a server for incoming requests, rather than waiting for messages to be pushed to a topic.

It is a prerequisite for adding tests for GAE, Cloud Run and Cloud Functions.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #563 (d123aa9) into main (cb447ae) will not change coverage.
The diff coverage is n/a.

❗ Current head d123aa9 differs from pull request most recent head 56746e8. Consider uploading reports for the commit 56746e8 to get more accurate results

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   64.00%   64.00%           
=======================================
  Files          37       37           
  Lines        4175     4175           
=======================================
  Hits         2672     2672           
  Misses       1390     1390           
  Partials      113      113           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole dashpole marked this pull request as ready for review January 9, 2023 22:53
@dashpole dashpole requested a review from damemi January 9, 2023 22:53
@dashpole
Copy link
Contributor Author

This is ready for review. It is a subset of the changes in #551, which now passes the gae/cloud run presubmits.

@dashpole dashpole merged commit be445f3 into GoogleCloudPlatform:main Jan 10, 2023
@dashpole dashpole deleted the push_server branch January 10, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants