Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark gcp resource detector stable #569

Merged
merged 1 commit into from Jan 13, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jan 11, 2023

This graduates the gcp resource detector library to stable in the next release.

@dashpole dashpole marked this pull request as ready for review January 13, 2023 19:26
@dashpole dashpole requested a review from damemi January 13, 2023 19:26
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #569 (d617dab) into main (cc4a77e) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   64.35%   64.16%   -0.19%     
==========================================
  Files          38       38              
  Lines        4216     4216              
==========================================
- Hits         2713     2705       -8     
- Misses       1390     1398       +8     
  Partials      113      113              
Impacted Files Coverage Δ
...lector/internal/datapointstorage/datapointcache.go 80.30% <0.00%> (-6.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole dashpole merged commit f1a3ebd into GoogleCloudPlatform:main Jan 13, 2023
@dashpole dashpole deleted the stable_detector branch January 13, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants