(logs exporter) Use a copy of shared log labels to prevent interference between LogRecords #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 64.18% 64.09% -0.10%
==========================================
Files 38 38
Lines 4219 4225 +6
==========================================
Hits 2708 2708
- Misses 1398 1404 +6
Partials 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dashpole
approved these changes
Jan 18, 2023
|
bypassing codecov, these lines are tested by fixtures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
Reproduced the original issue by adding a unique attribute to an entry in the test fixtures (saw that attribute copied to every output entry). Code changes fixed this, and fixtures work as expected now.