Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#580 didn't work because I was just checking the
request.LogName
field, which our exporter doesn't set (we set individual entry log names ie,request.Entries[i].LogName
). I also forgot to add the matching sort to the fixture generator.The tests still passed due to the randomness of the fixture ordering (until post-merge https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/actions/runs/4086503881). But, I should have caught this based on the fact that fixtures weren't updated in #580.
This sorts each entry in each request, then sorts the requests based on either their LogName or the LogName of the first entry in the request. This should be sufficiently deterministic for our tests.