Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/text from 0.3.7 to 0.3.8 in /tools #601

Merged
merged 1 commit into from Feb 24, 2023

Conversation

damemi
Copy link
Member

@damemi damemi commented Feb 24, 2023

dependabot threw a tantrum in #597 and stopped responding, so this makes the same change manually

@damemi damemi requested a review from a team as a code owner February 24, 2023 14:04
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #601 (2394c18) into main (9f7713b) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   63.52%   63.43%   -0.10%     
==========================================
  Files          38       38              
  Lines        4409     4409              
==========================================
- Hits         2801     2797       -4     
- Misses       1485     1489       +4     
  Partials      123      123              
Impacted Files Coverage Δ
...lector/internal/datapointstorage/datapointcache.go 80.30% <0.00%> (-3.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@psx95
Copy link
Contributor

psx95 commented Feb 24, 2023

There seems to be a minor reduction in codecov, I think because number of lines grew. The PR seems fine to me though.

Copy link
Contributor

@psx95 psx95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure exactly why the codecov reduced a little.

@damemi
Copy link
Member Author

damemi commented Feb 24, 2023

Not sure exactly why the codecov reduced a little.

codecov seems to dip a little on datapointcache.go in every PR. I haven't figured out why, might be worth looking into because it's annoying

@damemi damemi merged commit 3d7f1ed into GoogleCloudPlatform:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants