Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bool metrics #637

Merged
merged 21 commits into from
Jun 30, 2023
Merged

Support bool metrics #637

merged 21 commits into from
Jun 30, 2023

Commits on Jun 1, 2023

  1. Add support for bool valued metrics

    @psx95
    psx95 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    25a085c View commit details
    Browse the repository at this point in the history

  2. Adds collector specific example

    @psx95
    psx95 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1c68822 View commit details
    Browse the repository at this point in the history

  3. Remove debug print statements

    @psx95
    psx95 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    57b2d57 View commit details
    Browse the repository at this point in the history

  4. Add unit tests

    @psx95
    psx95 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    809c46e View commit details
    Browse the repository at this point in the history

  5. Remove lingering debug statement

    @psx95
    psx95 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    27f78e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Fix go lint error(s)

    @psx95
    psx95 committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f9b6474 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Remove special attribute keys prior to GCM export 

    The keys are removed from labelDescriptors and metricLabels so as to
prevent creation of separate time-series data for distinct values for
those labels.
    @psx95
    psx95 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    7cbcd4a View commit details
    Browse the repository at this point in the history

  2. Refactor: early return for better readability

    @psx95
    psx95 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    da9579c View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Revert "Adds collector specific example" 

    This reverts commit 1c68822.
    @psx95
    psx95 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6588dc8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into support-bool-metrics

    @psx95
    psx95 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2cfb696 View commit details
    Browse the repository at this point in the history

  3. Fix linter error

    @psx95
    psx95 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c9bfb45 View commit details
    Browse the repository at this point in the history

  4. Support boolean metrics via units

    @psx95
    psx95 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a4d5638 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Add log warning explaining failed bool conversion

    @psx95
    psx95 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    fa55019 View commit details
    Browse the repository at this point in the history

  2. Add missing tests to increase coverage

    @psx95
    psx95 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    133b6b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Add fixture based test for bool metrics

    @psx95
    psx95 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    777a342 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Invert check in convertMetricKindToBoolIfSupported 

    Co-authored-by: Mike Dame <mikedame@google.com>
    @psx95 @damemi
    psx95 and damemi committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    2f529b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Update test fixtures with additional cases

    @psx95
    psx95 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    caa5345 View commit details
    Browse the repository at this point in the history

  2. Fix documentation for numberDataPointToValue 

    Co-authored-by: Aaron Abbott <aaronabbott@google.com>
    @psx95 @aabmass
    psx95 and aabmass committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2d501be View commit details
    Browse the repository at this point in the history

  3. Update code formatting 

    Co-authored-by: Aaron Abbott <aaronabbott@google.com>
    @psx95 @aabmass
    psx95 and aabmass committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    626a0e4 View commit details
    Browse the repository at this point in the history

  4. Remove boolean support for Non-Monotonic Sum

    @psx95
    psx95 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    4331895 View commit details
    Browse the repository at this point in the history

  5. Rename convertMetricKindToBoolIfSupported -> convertToBoolIfMetricKin… 

    …dSupported
    @psx95
    psx95 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b9e9250 View commit details
    Browse the repository at this point in the history