Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint config #64

Merged

Conversation

james-bebbington
Copy link
Contributor

@james-bebbington james-bebbington commented Jul 8, 2020

Added lint config that runs more lint options by default. Updated make commands, and fixed all lint issues.

Also changed the condition for the flaky TestExporter_Timeout test

@james-bebbington james-bebbington changed the title Add lint config Fix CI commands & add lint config Jul 8, 2020
@james-bebbington james-bebbington changed the title Fix CI commands & add lint config [WIP] Fix CI commands & add lint config Jul 8, 2020
@james-bebbington james-bebbington marked this pull request as draft July 8, 2020 10:11
@james-bebbington james-bebbington changed the title [WIP] Fix CI commands & add lint config [WIP] Add lint config Jul 8, 2020
@james-bebbington james-bebbington force-pushed the improve-linter branch 9 times, most recently from 6198937 to 61b8b69 Compare July 9, 2020 01:57
@james-bebbington james-bebbington changed the title [WIP] Add lint config Add lint config Jul 9, 2020
@james-bebbington james-bebbington marked this pull request as ready for review July 9, 2020 01:58
Copy link
Contributor

@nilebox nilebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@james-bebbington james-bebbington merged commit f654a0b into GoogleCloudPlatform:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants