Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

covered test for injecting spans #65

Merged
merged 3 commits into from Jul 15, 2020
Merged

covered test for injecting spans #65

merged 3 commits into from Jul 15, 2020

Conversation

YANYZP
Copy link
Contributor

@YANYZP YANYZP commented Jul 9, 2020

test for #63

@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 9, 2020

Ready for final review

@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 13, 2020

Ready for final review

james-bebbington
james-bebbington approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise LGTM

exporter/trace/trace_proto_test.go Outdated Show resolved Hide resolved
@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 15, 2020

Real Final review

@nilebox nilebox merged commit 8fcf645 into GoogleCloudPlatform:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilebox nilebox nilebox left review comments

@james-bebbington james-bebbington james-bebbington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YANYZP @james-bebbington @nilebox