Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme section on metric label collisions #681

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

damemi
Copy link
Member

@damemi damemi commented Jul 19, 2023

Fixes #352
Document how to avoid metric label collisions with the transform processor, like https://cloud.google.com/stackdriver/docs/managed-prometheus/setup-otel#rename-resource-attributes

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets make sure this gets copied upstream as well, as users will look at that more often

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #681 (982d7b6) into main (f8434b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files          36       36           
  Lines        4699     4699           
=======================================
  Hits         3268     3268           
  Misses       1278     1278           
  Partials      153      153           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damemi
Copy link
Member Author

damemi commented Jul 19, 2023

LGTM. Lets make sure this gets copied upstream as well, as users will look at that more often

Sounds good. I also just added an update clarifying that the user's attributes might have . instead of _, but will still conflict once normalized, and to update the config if so

@damemi damemi merged commit a3fa73d into GoogleCloudPlatform:main Jul 19, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[collector metrics exporter] collisions with extra labels and metric labels
2 participants