Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: fix setting GetMetricDescriptor call options. #688

Merged
merged 1 commit into from Jul 26, 2023

Conversation

nimf
Copy link
Contributor

@nimf nimf commented Jul 26, 2023

Seems to be a copy/paste typo.

@nimf nimf requested a review from a team as a code owner July 26, 2023 00:17
@dashpole
Copy link
Contributor

/gcbrun

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #688 (051b406) into main (54bb068) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   69.14%   69.22%   +0.08%     
==========================================
  Files          36       36              
  Lines        4728     4728              
==========================================
+ Hits         3269     3273       +4     
+ Misses       1305     1301       -4     
  Partials      154      154              
Files Changed Coverage Δ
exporter/metric/metric.go 68.72% <0.00%> (ø)
exporter/metric/version.go 100.00% <100.00%> (ø)
exporter/trace/version.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole dashpole merged commit fbcefa9 into GoogleCloudPlatform:main Jul 26, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants