Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sanitization of logging labels from resource attributes #723

Merged
merged 2 commits into from Sep 20, 2023

Conversation

dashpole
Copy link
Contributor

Fixes #722

@dashpole dashpole requested a review from a team as a code owner September 20, 2023 18:40
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #723 (ea27c66) into main (82615d0) will decrease coverage by 0.35%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   69.75%   69.40%   -0.35%     
==========================================
  Files          42       42              
  Lines        4840     4847       +7     
==========================================
- Hits         3376     3364      -12     
- Misses       1313     1332      +19     
  Partials      151      151              
Files Changed Coverage Δ
exporter/collector/logs.go 44.47% <0.00%> (-0.88%) ⬇️
exporter/collector/metrics.go 73.01% <100.00%> (ø)
exporter/collector/monitoredresource.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

exporter/collector/logs.go Show resolved Hide resolved
@dashpole dashpole merged commit fe9ad49 into GoogleCloudPlatform:main Sep 20, 2023
23 of 25 checks passed
@dashpole dashpole deleted the cloud_logging_labels branch September 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Cloud Logging exporter converts resource labels from . to _
2 participants