Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new context for each bundle in trace exporter #74

Merged
merged 1 commit into from Jul 28, 2020
Merged

Create new context for each bundle in trace exporter #74

merged 1 commit into from Jul 28, 2020

Conversation

stevencl1013
Copy link
Contributor

Create new context for each bundle in trace exporter. Gets rid of contextAndSpans struct, just bundles spans.

nilebox
nilebox approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@nilebox nilebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilebox nilebox merged commit 2752da7 into GoogleCloudPlatform:master Jul 28, 2020
@nilebox nilebox mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilebox nilebox nilebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevencl1013 @nilebox