Metrics exporter cache requests that fail with an unrecoverable error #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilevy18
force-pushed
the
avilevy-cache-nonrecoverable-descriptors
branch
from
8e7a91b
to
d7081c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 69.52% 69.85% +0.33%
==========================================
Files 42 42
Lines 4859 4863 +4
==========================================
+ Hits 3378 3397 +19
+ Misses 1331 1315 -16
- Partials 150 151 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
/gcbrun |
punya
requested changes
Nov 9, 2023
|
@avilevy18 I'm planning to cut a release later today. If you can add test coverage by then, then we can include it. Let me know if we can help direct you. |
|
/gcbrun |
|
you can run |
|
/gcbrun |
dashpole
reviewed
Nov 13, 2023
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
|
/gcbrun |
dashpole
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765
When the metrics exporter fails to create a new metric descriptor any non-recoverable grpc errors will update the cache, preventing further CMD calls.