Provide useful cluster names for non k8s environments on managed prom… #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 69.85% 69.92% +0.06%
==========================================
Files 42 42
Lines 4863 4874 +11
==========================================
+ Hits 3397 3408 +11
Misses 1315 1315
Partials 151 151 ☔ View full report in Codecov by Sentry. |
punya
approved these changes
Nov 28, 2023
dashpole
reviewed
Nov 28, 2023
exporter/collector/googlemanagedprometheus/monitoredresource.go
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etheus exporter.
__run__on cloud run and__gce__on compute engine.cc @ridwanmsharif
Note: This just modifies the defaults, happy to provide docs or transition period.