Support gcp.source_location being set as other types #794
Conversation
By copying the logic from parsing gcp.http_request, this PR adds support to also parse `gcp.source_location` from types other than Bytes.
braydonk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 70.02% 70.30% +0.28%
==========================================
Files 42 42
Lines 4877 4886 +9
==========================================
+ Hits 3415 3435 +20
+ Misses 1311 1303 -8
+ Partials 151 148 -3 ☔ View full report in Codecov by Sentry. |
|
/gcbrun |
To make codecov happy :)
To make codecov EVEN MORE happy :)
exporter/collector/logs_test.go
Outdated
| @@ -396,6 +395,103 @@ func TestLogMapping(t *testing.T) { | |||
| }, | |||
| maxEntrySize: defaultMaxEntrySize, | |||
| }, | |||
| { | |||
| name: "log with bad source location (bytes)", | |||
There was a problem hiding this comment.
It's because the value provided for gcp.source_location can't actually be parsed, the json Unmarshal fails due to an invalid type in one of the fields. Is there a nicer way I should say that concisely in the test or should I add a comment?
There was a problem hiding this comment.
"log with wrong type in sourceLocation (bytes)", perhaps?
* Renamed `bytes` to `valueBytes` to avoid import shadow * Moved `expectedError` to top of the test case struct to handle field alignment error
|
/gcbrun |
|
@quentinmit i'll wait for your approval to merge |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Let's see if the e2e tests will work today 🙏 |
|
/gcbrun |
|
I still don't seem to have permission to run these :( |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
By copying the logic from parsing gcp.http_request, this PR adds support to also parse
gcp.source_locationfrom types other than Bytes.This fixes the basic case of #792 such that the collector does not panic when setting
gcp.source_locationas something other than bytes.