Add fixture with a histogram exemplar, and implement exemplar attachments in SDK #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
approved these changes
Mar 6, 2024
|
This now implements exemplar attachments as well. I had to do that to get the fixture tests to pass. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 59.90% 60.07% +0.17%
==========================================
Files 56 56
Lines 5749 5854 +105
==========================================
+ Hits 3444 3517 +73
- Misses 2155 2186 +31
- Partials 150 151 +1 ☔ View full report in Codecov by Sentry. |
dashpole
changed the title
dashpole
force-pushed
the
test_int_exemplar
branch
from
49d9bae
to
5c4603e
Compare
aabmass
approved these changes
Mar 6, 2024
|
We have int64 histogram exemplars from the fixture test now: 
|
dashpole
force-pushed
the
test_int_exemplar
branch
from
2a83834
to
f19eae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806
This makes sure exemplar support, which was fixed in #810 displays correctly in the UI for histograms