Add additional fallbacks for GMP exporter #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Mar 21, 2024
exporter/collector/googlemanagedprometheus/monitoredresource.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 60.00% 60.04% +0.04%
==========================================
Files 56 56
Lines 5896 5902 +6
==========================================
+ Hits 3538 3544 +6
Misses 2206 2206
Partials 152 152 ☔ View full report in Codecov by Sentry. |
dashpole
reviewed
Mar 21, 2024
...er/collector/integrationtest/testdata/fixtures/metrics/google_managed_prometheus_expect.json
Show resolved
Hide resolved
damemi
commented
Mar 22, 2024
exporter/collector/googlemanagedprometheus/extra_metrics_test.go
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799